[ISSUE-328] Cleanup unused shuffle servers after stage completed#334
Merged
zuston merged 2 commits intoapache:masterfrom Nov 18, 2022
Merged
[ISSUE-328] Cleanup unused shuffle servers after stage completed#334zuston merged 2 commits intoapache:masterfrom
zuston merged 2 commits intoapache:masterfrom
Conversation
zuston
reviewed
Nov 17, 2022
Member
zuston
left a comment
zuston
left a comment
There was a problem hiding this comment.
Overall LGTM. Left some minor comments.
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
============================================
+ Coverage 61.21% 61.30% +0.08%
- Complexity 1506 1519 +13
============================================
Files 185 185
Lines 9360 9440 +80
Branches 908 924 +16
============================================
+ Hits 5730 5787 +57
- Misses 3325 3343 +18
- Partials 305 310 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
changed the title
3 tasks
zuston
approved these changes
Nov 18, 2022
Member
zuston
left a comment
zuston
left a comment
There was a problem hiding this comment.
LGTM. Thanks @xianjingfeng
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cleanup unused shuffle servers after stage completed
Why are the changes needed?
If there are many stages in one applicaiton, spark driver will send heartbeat to every shuffle servers, and it may cause app expired in shuffle server side. And if we support decommission in the future, it will cause shuffle difficult to exit. #328
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added